Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

service: add ark-network/ark #202

Merged
merged 8 commits into from
Dec 28, 2024
Merged

service: add ark-network/ark #202

merged 8 commits into from
Dec 28, 2024

Conversation

tiero
Copy link
Member

@tiero tiero commented Dec 27, 2024

Add Ark and improve testing

What's Changed

🎯 Add Ark

  • Added Ark as default Bitcoin layer two solution
  • New commands: nigiri ark and nigiri arkd for wallet management
  • Updated docs with Ark usage examples and initialization steps

🧪 Better Testing

  • Introduced Docker client interface and mock implementation
  • No more Docker-in-Docker testing headaches
  • Consolidated Docker code for better maintainability

🔧 Code Cleanup

  • Organized commands in logical groups (Core, Bitcoin/Elements, Ark, Lightning)
  • Better service endpoints logging
  • Unified YAML parsing and error handling
image

Try it out!

Start with Ark enabled

$ nigiri start --ark

Initialize Ark wallet

$ nigiri ark init --network regtest --password secret --server-url localhost:7070

@tiero tiero changed the title add ark-network/ark and gitignore volumes dir service: add ark-network/ark Dec 27, 2024
@tiero tiero requested a review from altafan December 28, 2024 00:32
Comment on lines +243 to +256
environment:
ARK_ROUND_INTERVAL: "15"
ARK_LOG_LEVEL: "5"
ARK_NETWORK: "regtest"
ARK_PORT: "7070"
ARK_NO_TLS: "true"
ARK_NO_MACAROONS: "true"
ARK_TX_BUILDER_TYPE: "covenantless"
ARK_BITCOIND_RPC_USER: "admin1"
ARK_BITCOIND_RPC_PASS: "123"
ARK_BITCOIND_RPC_HOST: "bitcoin:18443"
ARK_BITCOIND_ZMQ_BLOCK: "tcp://bitcoin:28332"
ARK_BITCOIND_ZMQ_TX: "tcp://bitcoin:28333"
ARK_DATADIR: "/app/data"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these good for dev? @altafan

@tiero tiero merged commit 16cd19c into vulpemventures:master Dec 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant