Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

Update vulcanize to properly handle dep's issue with case insensitivity (for github repos) #59

Closed
elizabethengelman opened this issue Jun 12, 2018 · 2 comments
Assignees

Comments

@elizabethengelman
Copy link
Contributor

elizabethengelman commented Jun 12, 2018

Based on golang/dep#433 it seems that dep is not able to handle case insensitivity, specifically with github. This is causing some weird behavior in VDB, like adding VulcanizeDB into it's own vendor directory.

Steps to reproduce:

  • clone the project
  • cd into the VulcanizeDB directory that was created
  • run dep ensure
  • notice that "github.com/vulcanize/vulcanizedb" is added to Gopkg.lock as a dependency
  • if you make a change to your local VulcanizeDB project (i.e. add an extra print statement to the sync command) and then rebuild, the change you've made will not be reflected. I think that this is because the binary that is created is using the "vendored vulcanize db" instead

A quick fix is to locally change the VulcanizeDB directory to vulcanizedb (no capitals), but we should instead figure out a better way to handle this - perhaps changing the repo name would help, but maybe there is another solution.

@elizabethengelman elizabethengelman changed the title Update vulcanize to properly handle dep not handling case insensitivity with github repos Update vulcanize to properly handle dep's issue with case insensitivity (for github repos) Jun 12, 2018
@AFDudley AFDudley self-assigned this Jun 14, 2018
@AFDudley
Copy link
Contributor

Please confirm the name changed fixed this issue, thanks.

@elizabethengelman
Copy link
Contributor Author

The repo name change seemed to fix this issues, so I'll close this issue. Thanks!

i-norden pushed a commit that referenced this issue Apr 18, 2019
Gslaughl pushed a commit that referenced this issue Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants