-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(useActiveElement/useFocusWithin): replace computedWithControl with locally tracked ref #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
This PR changes 10-29 lines, ignoring generated files.
label
Feb 22, 2024
antfu
approved these changes
Feb 27, 2024
This was referenced Feb 27, 2024
webdesignberlin
added a commit
to FitX/customer-components
that referenced
this pull request
Feb 29, 2024
- update deps to fix vueuse/vueuse#3794 via vueuse/vueuse#3815
noook
pushed a commit
to noook/vueuse
that referenced
this pull request
Mar 26, 2024
…h locally tracked ref (vueuse#3815)
This was referenced May 25, 2024
This was referenced Jul 3, 2024
This was referenced Jul 24, 2024
This was referenced Sep 3, 2024
This was referenced Sep 11, 2024
This was referenced Sep 18, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
fixes #123
).Description
useActiveElement and useFocusWithin are currently broken due to computedWithControl being used inside of computed triggering the following warning:
This PR replaces computedWithControl with a locally tracked ref so useActiveElement can be used inside a computed as done in useFocusWithin:
vueuse/packages/core/useFocusWithin/index.ts
Lines 23 to 25 in 1b67d96
Additional context
related issues: #3799, #3794, #3787, #3774, #3760
upstream issue: vuejs/core#10341