Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: leaving hovered state when pointer hovers child element #194

Merged
merged 1 commit into from
May 29, 2024
Merged

fix: leaving hovered state when pointer hovers child element #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/features/eventListeners.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,6 @@ export function registerEventListeners<T extends string, V extends MotionVariant
hovered.value = false
tapped.value = false
})
useEventListener(target as any, 'mouseout', () => {
hovered.value = false
tapped.value = false
})
}

// Tapped
Expand Down
11 changes: 9 additions & 2 deletions tests/components.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,9 +120,16 @@ describe.each([

expect(el.style.transform).toEqual('scale(1.2) translateZ(0px)')

// Should return to initial
// Should do nothing on 'mouseout'
await wrapper.trigger('mouseout')
// TODO: figure out a better way to test if a variant is not triggered than timeouts
await nextTick()
await new Promise((resolve) => setTimeout(resolve, 1000))
await waitForMockCalls(onComplete, 0)

// Should return to initial, 'mouseleave' triggers when pointer left element and all descendants
await wrapper.trigger('mouseleave')
await waitForMockCalls(onComplete)
await waitForMockCalls(onComplete, 1)

expect(el.style.transform).toEqual('scale(1) translateZ(0px)')
})
Expand Down
Loading