Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDataTable): display non-string item values #8562

Merged
merged 5 commits into from
Nov 20, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #8554

How Has This Been Tested?

visually, jest

Markup:

<template>
  <v-data-table
    :headers="[{value: 'foo'}]"
    :items="[{foo: 'a'}, {foo: true}, {foo: false}, {foo: new Date()}, {foo: [1,2]}, {foo: 123}]"
  />
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Aug 15, 2019
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.x milestone Aug 15, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Aug 15, 2019
@TravisBuddy
Copy link

TravisBuddy commented Aug 16, 2019

Hey @jacekkarczmarczyk,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: eeec8c80-f47d-11e9-9e2b-01a46d152451

nekosaur
nekosaur previously approved these changes Aug 16, 2019
Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstract function into shared util for tables. Write specific test for it and remove the component ones.

@KaelWD KaelWD modified the milestones: v2.0.x, v2.1.x Oct 2, 2019
@johnleider
Copy link
Member

Pulse check.

@johnleider johnleider modified the milestones: v2.1.x, v2.2.x Oct 11, 2019
@jacekkarczmarczyk
Copy link
Member Author

Abstract function into shared util for tables. Write specific test for it and remove the component ones.

@johnleider not sure if it's a good idea, if someone removes usage of this function from the data table component test will still pass. Also it's just a tiny pieces of code used in only 2 places, so no much gain with extracting it out

@johnleider johnleider modified the milestones: v2.2.x, v2.1.x Nov 20, 2019
@johnleider johnleider merged commit c3789d9 into master Nov 20, 2019
@johnleider johnleider deleted the fix/#8554-non-string-values-in-data-table branch November 20, 2019 22:49
@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VDataTable VDatatable T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-data-table does not display boolean values
5 participants