-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VDataTable): display non-string item values #8562
Conversation
Hey @jacekkarczmarczyk, TravisBuddy Request Identifier: eeec8c80-f47d-11e9-9e2b-01a46d152451 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abstract function into shared util for tables. Write specific test for it and remove the component ones.
Pulse check. |
@johnleider not sure if it's a good idea, if someone removes usage of this function from the data table component test will still pass. Also it's just a tiny pieces of code used in only 2 places, so no much gain with extracting it out |
Motivation and Context
fixes #8554
How Has This Been Tested?
visually, jest
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).