Filter comments to count actual rendered elements

[ebisbe]

Description

Motivation and Context

Fixes #4114

How Has This Been Tested?

unit ( snapshot)

Markup:

<template>
  <v-app id="inspire">
    <v-list two-line>
      <v-list-tile>
        <v-list-tile-content>
          <v-list-tile-title>some title</v-list-tile-title>
        </v-list-tile-content>
        <v-list-tile-action>
          <v-list-tile-action-text>Something</v-list-tile-action-text>
          <v-btn v-if="true">a</v-btn>
          <v-btn v-if="false">b</v-btn>
        </v-list-tile-action>
      </v-list-tile>
    </v-list>

    <v-list two-line>
      <v-list-tile>
        <v-list-tile-content>
          <v-list-tile-title>some title</v-list-tile-title>
        </v-list-tile-content>
        <v-list-tile-action>
          <v-btn v-if="true">a</v-btn>
          <v-btn v-if="false">b</v-btn>
        </v-list-tile-action>
      </v-list-tile>
    </v-list>


    <v-list two-line>
      <v-list-tile>
        <v-list-tile-content>
          <v-list-tile-title>some title</v-list-tile-title>
        </v-list-tile-content>
        <v-list-tile-action>
          <v-btn v-if="true">a</v-btn>
        </v-list-tile-action>
      </v-list-tile>
    </v-list>

    <v-list two-line>
      <v-list-tile>
        <v-list-tile-content>
          <v-list-tile-title>some title</v-list-tile-title>
        </v-list-tile-content>
        <v-list-tile-action>
          <v-list-tile-action-text>Hola</v-list-tile-action-text>
          <v-btn v-if="true">a</v-btn>
          <v-btn v-else>b</v-btn>
        </v-list-tile-action>
      </v-list-tile>
    </v-list>
  </v-app>
</template>

<script>
export default {
  data() {
    return {};
  }
};
</script>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes, dev for new features and breaking changes).
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have created a PR in the documentation with the necessary changes.

[codecov]

Codecov Report

Merging #4657 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #4657      +/-   ##
==========================================
- Coverage   90.14%   90.11%   -0.03%     
==========================================
  Files         206      206              
  Lines        4919     4935      +16     
  Branches     1249     1257       +8     
==========================================
+ Hits         4434     4447      +13     
- Misses        388      391       +3     
  Partials       97       97

Impacted Files	Coverage Δ
src/components/VList/VListTileAction.js	100% <100%> (ø)	⬆️
src/components/transitions/expand-transition.js	55.55% <0%> (-3.27%)	⬇️
src/mixins/validatable.js	95.16% <0%> (-1.51%)	⬇️
.../components/VNavigationDrawer/VNavigationDrawer.js	67.77% <0%> (-0.04%)	⬇️
src/components/VAutocomplete/VAutocomplete.js	98.19% <0%> (-0.04%)	⬇️
src/components/VSelect/VSelect.js	95.18% <0%> (-0.03%)	⬇️
src/components/VFooter/VFooter.js	100% <0%> (ø)	⬆️
src/components/VSelect/VSelectList.js	97.1% <0%> (+0.04%)	⬆️
src/mixins/overlayable.js	47.19% <0%> (+0.06%)	⬆️
src/util/helpers.ts	91.91% <0%> (+0.16%)	⬆️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95a80a...fbc5a35. Read the comment docs.

[KaelWD]

Maybe I shouldn't've marked that "good first issue", it relies on knowledge of some vue internals. Also please test contributions with actual code too, unit tests alone aren't enough.

[ebisbe]

What vue internals?
Test with the playground also? What do you mean with the second phrase?

[johnleider]

filter will always return an array, you can remove the ||

[johnleider]

Can you add a playground?

[ebisbe]

Added Playground and filtered out empty VNodes to make the count

[ebisbe]

@johnleider Anything more to do?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord