Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add russian locale #4425

Merged
merged 1 commit into from
Jul 9, 2018
Merged

feat: add russian locale #4425

merged 1 commit into from
Jul 9, 2018

Conversation

Djaler
Copy link
Contributor

@Djaler Djaler commented Jun 29, 2018

Just a russian locale

@jacekkarczmarczyk
Copy link
Member

@vuetifyjs/dev-team should we name files ru.js, en.js, es.js or ru_RU.js, en_US.js, en_GB.js, es_MX.js etc?

@KaelWD KaelWD mentioned this pull request Jul 1, 2018
@KaelWD
Copy link
Member

KaelWD commented Jul 1, 2018

Simple names are fine, especially for languages with only slight regional variation.

@KaelWD KaelWD added this to the v1.2.0 milestone Jul 1, 2018
@johnleider johnleider added the semver: minor Contains backward compatible API changes label Jul 9, 2018
@KaelWD KaelWD changed the title Add russian locale feat: add russian locale Jul 9, 2018
@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #4425 into dev will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #4425      +/-   ##
=========================================
- Coverage   89.6%   89.23%   -0.37%     
=========================================
  Files        206      206              
  Lines       4875     4868       -7     
  Branches    1229     1225       -4     
=========================================
- Hits        4368     4344      -24     
- Misses       408      418      +10     
- Partials      99      106       +7
Impacted Files Coverage Δ
src/components/VTextField/index.js 76.47% <0%> (-1.31%) ⬇️
src/components/VSelect/index.js 62.85% <0%> (-1.04%) ⬇️
src/util/helpers.ts 91.66% <0%> (-0.18%) ⬇️
src/components/VSelect/VSelect.js 92.06% <0%> (-0.05%) ⬇️
src/components/VIcon/VIcon.ts 100% <0%> (ø) ⬆️
src/components/VSwitch/VSwitch.js 100% <0%> (ø) ⬆️
src/components/VTabs/VTabItem.js 100% <0%> (ø) ⬆️
src/util/colorUtils.ts 100% <0%> (ø) ⬆️
src/components/VTabs/VTabs.js 100% <0%> (ø) ⬆️
src/directives/touch.ts
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52dc6c0...67b59ea. Read the comment docs.

@KaelWD KaelWD merged commit 0e7e0bc into vuetifyjs:dev Jul 9, 2018
YoanChapron pushed a commit to YoanChapron/vuetify that referenced this pull request Jul 18, 2018
beatgrabe pushed a commit to beatgrabe/vuetify that referenced this pull request Jul 31, 2018
@lock
Copy link

lock bot commented Apr 15, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
semver: minor Contains backward compatible API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants