-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VList): add prependSpacer prop #20616
base: dev
Are you sure you want to change the base?
Conversation
Does it make it too complex to reduce the spacing between parent/child as well? Playground used: |
Setting sass variable |
FYI: I'm still trying to fix the indent issue. It's a complicated one but I found the problem, it's the --prepend css modifier applied incorrectly in nested scenario. Trying to find a solution atm |
e90e191
to
0143f1e
Compare
Did regression testing on docs (VTreeview & VList), all good. But there is one caveat: Indent only works properly if ✅ Works <v-list-group
prepend-icon="mdi-home"
value="Admin"
>
<template v-slot:activator="{ props }">
<v-list-item
v-bind="props"
title="Admin"
></v-list-item>
</template>
</v-list-group> ❌ Doesn't work <v-list-group
value="Admin"
>
<template v-slot:activator="{ props }">
<v-list-item
v-bind="props"
prepend-icon="mdi-home"
title="Admin"
></v-list-item>
</template>
</v-list-group> Making the latter sample work requires js logic (to somehow access activator slot), but I would rather keep everything in css unless the latter use case is desperately required |
Can we add a Alert in the docs about it? |
Done, this PR is ready |
Description
Markup: