feat(VDataTable): Screenreader suport for sorting #20594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For screenreader users there was no possibility to dtermine wether a table column is sortable or not. The sort status was not readable too. This commit fixes this problem. In theory aria-sort can only be set to one table header
(see https://www.w3.org/TR/wai-aria-1.2/#aria-sort),
but in most screen readers it's even working with multiple columns containing aria-sort. For others it's only anouncing the first one, so i think setting it on every column which has an order set is the best option.
Markup:
<script> export default { name: 'Playground', setup () { return { items: [{ name: 'bla', test: 'test1' }, { name: 'blu', test: 'test2' }], } }, } </script>