Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include modern sass vite options #20325

Merged
merged 8 commits into from
Aug 17, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Aug 13, 2024

Description

This PR adds a new section in Caveats to enable SASS modern Vite options for Vite and Nuxt.

Markup:

NA

@KaelWD
Copy link
Member

KaelWD commented Aug 15, 2024

https://vitejs.dev/config/shared-options.html#css-preprocessoroptions says to also use sass-embedded

@userquin
Copy link
Member Author

https://vitejs.dev/config/shared-options.html#css-preprocessoroptions says to also use sass-embedded

Then you need to replace sass with sass-embedded: check vitejs/vite#17728 (comment)

Will Vuetify work with sass-embedded?. IIRC you closed a PR about deprecated mixed-decl: we need to do some tests, I'm not a sass expert.

@KaelWD
Copy link
Member

KaelWD commented Aug 15, 2024

I hadn't seen the PR and it didn't link the issue so I fixed it myself: #20139

They used our code in that test so I don't see why it wouldn't work.

@KaelWD KaelWD force-pushed the master branch 2 times, most recently from e20cfec to 2766105 Compare August 15, 2024 09:17
@userquin userquin merged commit 32362f7 into master Aug 17, 2024
18 checks passed
@userquin userquin deleted the userquin/docs-include-modern-sass-vite-options branch August 17, 2024 12:02
blalan05 pushed a commit that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants