Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): card-actions add margin-inline-start only for for direct btns #20262

Closed
wants to merge 2 commits into from

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Aug 1, 2024

Description

fixes #20239

Breaking change: v-card-actions only impacts its immediate child v-btns

Markup:

<template>
  <v-app>
    <v-container>
      <v-number-input control-variant="stacked" />
    </v-container>
    <v-card-actions>
      <v-btn text="one" />
      <v-btn text="two" />
    </v-card-actions>
    <v-card-actions>
      <v-number-input control-variant="stacked" />
    </v-card-actions>
  </v-app>
</template>

@yuwu9145 yuwu9145 requested a review from KaelWD August 1, 2024 00:05
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VBtn VBtn labels Aug 1, 2024
@yuwu9145
Copy link
Member Author

yuwu9145 commented Aug 1, 2024

@KaelWD Does this look like a breaking change to you? Might need to rebase to dev

@yuwu9145 yuwu9145 changed the base branch from master to dev August 1, 2024 23:22
@yuwu9145 yuwu9145 added this to the v3.7.0 (Odyssey) milestone Aug 1, 2024
@KaelWD
Copy link
Member

KaelWD commented Aug 15, 2024

It provides slim: true and variant: 'text' to non-direct children too so the old description is more correct. I think we could also use gap here instead of margin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtn VBtn T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.6.13] Unexpected margin on VNumberInput button when in VCardActions
4 participants