Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VAutocomplete/VCombobox): remove tab key listener #19846

Merged
merged 2 commits into from
May 21, 2024
Merged

Conversation

yuwu9145
Copy link
Member

For autocomplete/comobobox, "Tab" key is equivalent to "blur", so remove tab key listener and let isFocused === false watcher handle "auto-select-first"

fixes #19840

Description

Markup:

<template>
  <v-app>
    <v-container>
      <v-combobox
        chips
        label="Combobox"
        :items="['California1', 'California2', 'California3', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
        multiple
        hide-selected
        auto-select-first
      />
      <v-autocomplete
        chips
        label="Autocomplete"
        :items="['California1', 'California2', 'California3', 'Colorado', 'Florida', 'Georgia', 'Texas', 'Wyoming']"
        multiple
        hide-selected
        auto-select-first
      />
    </v-container>
  </v-app>
  <!-- 
  1. Type Cal
  2. Hit tab
  3. Notice California1 and California2 are populated to input field.
  4. Behavior does not occur if you type Cal, arrow down to California2 and tab.

  Appears to have broken in 3.3.11 release. Was working in 3.3.10
        -->
</template>

@yuwu9145 yuwu9145 requested review from johnleider and KaelWD May 21, 2024 06:48
@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VCombobox VCombobox C: VAutocomplete VAutocomplete labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VAutocomplete VAutocomplete C: VCombobox VCombobox T: bug Functionality that does not work as intended/expected
Projects
None yet
3 participants