Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTabs): add support for v-tabs-window #19248

Merged
merged 10 commits into from
Apr 10, 2024
Merged

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Feb 20, 2024

Motivation and Context

add support for missing v-tabs-window/v-tabs-window-item (v-tab-items/v-tab-item)

TODO:

  • center-active is broken

Markup:

<template>
  <v-app>
    <div class="ma-4 pa-4">
      <v-tabs :items="items">
        <template #item.Tab1>
          Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
        </template>
        <template #item.Tab2>
          2Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
        </template>
        <template #item.Tab3>
          3Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
        </template>
      </v-tabs>
    </div>

    <div class="ma-4 pa-4">
      <v-tabs>
        <v-tab text="Tab 1" value="1" />
        <v-tab text="Tab 2" value="2" />
        <v-tab text="Tab 3" value="3" />

        <template #window>
          <v-tabs-window-item value="1">
            Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
          <v-tabs-window-item value="2">
            2Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
          <v-tabs-window-item value="3">
            2Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
        </template>
      </v-tabs>
    </div>

    <div class="ma-4 pa-4">
      <v-tabs>
        <v-tab text="Tab 1" />
        <v-tab text="Tab 2" />
        <v-tab text="Tab 3" />

        <template #window>
          <v-tabs-window-item>
            Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
          <v-tabs-window-item>
            2Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
          <v-tabs-window-item>
            2Lorem ipsum dolor sit amet consectetur adipisicing elit. Commodi, ratione debitis quis est labore voluptatibus! Eaque cupiditate minima, at placeat totam, magni doloremque veniam neque porro libero rerum unde voluptatem!
          </v-tabs-window-item>
        </template>
      </v-tabs>
    </div>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'

  const items = ['Tab1', 'Tab2', 'Tab3']
  const model = ref()
  const model2 = ref()
</script>

@johnleider johnleider self-assigned this Feb 20, 2024
@MajesticPotatoe MajesticPotatoe added T: feature A new feature C: VTabs VTabs labels Feb 26, 2024
@johnleider johnleider force-pushed the feat/add-tabs-window-support branch from 51fb8b0 to 08b7ae6 Compare March 18, 2024 15:26
@johnleider johnleider marked this pull request as ready for review April 1, 2024 02:41
@johnleider johnleider requested review from KaelWD and a team and removed request for KaelWD April 1, 2024 02:42
@johnleider johnleider force-pushed the feat/add-tabs-window-support branch from 39933a2 to 296ff84 Compare April 4, 2024 02:42
@johnleider johnleider added this to the v3.6.0 (Nebula) milestone Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTabs VTabs T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants