Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Closing v-dialog also closes temporary v-navigation-drawer #5089

Closed
DRoet opened this issue Sep 13, 2018 · 4 comments
Closed

[Bug Report] Closing v-dialog also closes temporary v-navigation-drawer #5089

DRoet opened this issue Sep 13, 2018 · 4 comments
Assignees
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected T: enhancement Functionality that enhances existing features
Milestone

Comments

@DRoet
Copy link
Contributor

DRoet commented Sep 13, 2018

Versions and Environment

Vuetify: 1.2.3
Vue: 2.5.17
Browsers: Chrome 69.0.3497.81
OS: Windows 10

Steps to reproduce

  1. Open the temporary drawer by opening the codepen
  2. open the dialog by clicking the button
  3. attempt to close the dialog by clicking outside of it

Expected Behavior

only the dialog will close, the drawer should remain open

Actual Behavior

both the dialog and drawer close

Reproduction Link

https://codepen.io/anon/pen/VGdKMW

@RobbinBaauw
Copy link
Contributor

RobbinBaauw commented Sep 13, 2018

I think it doesn't have to do with the dialog, as clicking anywhere outside of the drawer will make the drawer close, so closing the dialog also closes the drawer as you clicked outside of the drawer (try clicking the text in the dialog for example). Whether this is expected behaviour, I don't know.

@johnleider
Copy link
Member

This has to do with dependent elements. Unfortunately the changes will require some minor refactoring throughout as adding the dependent mixin to v-navigation-drawer will alter other layout functionality.

This is something that we should do.

@johnleider johnleider added this to the v2.0.0 milestone Sep 14, 2018
@johnleider johnleider added T: bug Functionality that does not work as intended/expected T: enhancement Functionality that enhances existing features labels Sep 14, 2018
@DRoet
Copy link
Contributor Author

DRoet commented Sep 14, 2018

@johnleider I tried pulling in the dependent mixin like you suggested just to test it out and it works:
https://github.com/DRoet/vuetify/commit/d7318a6764438445b9b3c735d7116b55509eb50a

I was just wondering if you could clarify the "will alter other layout functionality" since I couldn't find anything from my testing

@johnleider johnleider added the S: has PR The issue has a pending Pull Request label Sep 18, 2018
@johnleider
Copy link
Member

I probably should have said could alter other layout functionality. PR looks good, will go with next PATCH.

johnleider added a commit that referenced this issue Sep 19, 2018
fix(v-navigation-drawer): pull in Dependent mixin for click-outside
@johnleider johnleider modified the milestones: v2.0.0, v1.3.0 Sep 25, 2018
@johnleider johnleider self-assigned this Sep 25, 2018
@DRoet DRoet closed this as completed Sep 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
S: has PR The issue has a pending Pull Request T: bug Functionality that does not work as intended/expected T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

3 participants