-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] Emit a 'save' event from the v-edit-dialog component. #3197
Comments
+1 My simple validation now broken:( beta.4 is my stable life preserver for now. |
Why? Without this edit dialog mostly not useful:( Will be great return "open" also. |
Folks, i was wrong. Save event does not decide anything. VEditDialog mostly proof of concept. Universal decision maybe does not exist at all. Aim: So only "save" does not change anything. |
same as here. I need a 'save' event to get data that needs updating compared to updating the entire table. currently i use 'watch' to see the data that needs to update. Please restore the 'save' event |
Hi, same as here. I resolve this by using change event in v-text-field. thank you. |
Yep, same here - all my inline-editing functionality was broken after the update ... why were the events removed from the component? |
I would file that as a bug since it was working before and now it seems just accidentially gone, right? |
I have solved by simple using <v-text-field
slot="input"
label="Edit"
v-model="props.item.name"
single-line
counter
@keyup.enter="updateName(props.item._id, props.item.name)"
:rules="[required]"
>
</v-text-field> |
@robertsLando |
For the time being, here's how I'm hooking the
I noticed the returnable mixin has the following, but I'm not sure how to capture the emitted event.
|
@tvkit |
* fix (v-edit-dialog): restores **save** event fixes #3197 * fix(VEditDialog): restored open/close/cancel events
New Functionality
It will allow the developer to know when the user has finally finished his editing and will not cancel his changes in the future.
Improvements
Currently you need to create custom buttons with click events to achieve this, which renders the no-button v-edit-dialog obsolete.
Bugs or Edge Cases it Helps Avoid
The return-value.sync props gets updated 'on-change' and not 'on-save' making it impossible (with no custom buttons) to know when the user is done making changes or not. See example pen below which demonstrates the issue when using the return-value.sync alone:
https://codepen.io/anon/pen/qxadqb?editors=1010
The text was updated successfully, but these errors were encountered: