Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Fullscreen dialogs don't cover scrollbar on bigger resolutions #3101

Closed
hymair opened this issue Jan 25, 2018 · 1 comment
Closed

[Bug Report] Fullscreen dialogs don't cover scrollbar on bigger resolutions #3101

hymair opened this issue Jan 25, 2018 · 1 comment
Assignees
@johnleider
Labels
T: enhancement Functionality that enhances existing features
Milestone
v1.2.x

Comments

@hymair
Copy link
Contributor

hymair commented Jan 25, 2018 •
edited
Loading

Versions and Environment

Vuetify: 1.0.0-beta.5
Vue: 2.5.13
Browsers: Chrome 63.0.3239.132
OS: Linux x86_64

Steps to reproduce

  1. Shrink codepen sidebar to < 959px; toggle dialog -> no double scrollbar.
  2. Resize to >= 960px; toggle dialog -> double scrollbar.

Expected Behavior

Consistency between resolutions. Fullscreen dialogs should always overlay the page scrollbar.

Actual Behavior

@ < 959px the fullscreen dialog correctly hides the underlying scrollbar.
@ >= 960px results in double scrollbar.

Reproduction Link

https://codepen.io/anon/pen/BJgZYa
@johnleider johnleider added T: enhancement Functionality that enhances existing features help wanted We are looking for community help labels Feb 3, 2018
@hymair hymair mentioned this issue Jun 19, 2018
Closed
@KaelWD KaelWD removed the help wanted We are looking for community help label Jun 19, 2018
@KaelWD KaelWD added this to the v1.2.0 milestone Jun 19, 2018
@johnleider johnleider modified the milestones: v1.2.0, v1.3.0 Aug 25, 2018
@johnleider johnleider self-assigned this Oct 9, 2018
johnleider added a commit that referenced this issue Oct 9, 2018
@johnleider
fix(v-dialog): always remove scrollbar when fullscreen
ff5d07b 
fixes #3101
@johnleider
Copy link
Member

Closed via ff5d07b

@johnleider johnleider modified the milestones: v1.3.0, v1.2.x Oct 9, 2018
lzhoucs added a commit to lzhoucs/vuetify that referenced this issue Oct 10, 2018
@lzhoucs
Merge 1.2.8 (#21)
7b41fa7 
* Filter comments to count actual rendered elements

* Remove unnecesary conditional

* Filter out VNodes with empty text

* fix(VImg): allow transition to be disabled

* fix(v-combobox): update onEnterDown logic

should let v-select-list handle the update if user is selecting index

fixes vuetifyjs#5008

* fix(v-slider): remove duplicate change event

onMouseUp is already triggered by v-input, our mouseUp usage is more internal for slider, just
renamed method

fixes vuetifyjs#4996

* fix(v-combobox): prevent default action

when using a combobox, enter should be treated differently and not invoke a form submit

fixes vuetifyjs#4974

* fix(VMenu): make detached provide reactive

fixes vuetifyjs#5010

* fix(VBreadcrumbs): add Themeable classes

fixes vuetifyjs#4986

* Fix vuetifyjs#3904: dividers are not shown in dynamic vertical stepper (vuetifyjs#4767)

* Fix vuetifyjs#4696: Checkbox is hard to click with ripple disabled (vuetifyjs#4776)

* test(v-stepper-ccontent): add provide

* [release] 1.2.2

* V-Autocomplete: hide-no-data also controls opening menu upon item update

fixes vuetifyjs#4663

* fix(v-footer): fix applicationProperty update

add new value for inset footer to applicationable

fixes vuetifyjs#4686

* [release] 1.1.16

* [release] 1.2.3

* fix(VMenu): inherit light/dark from v-app

playground: https://pastebin.com/raw/jtLrtVtP

* fix(DatePicker): Title spacing when month === August (vuetifyjs#5027)

* fix(v-autocomplete): add conditional for single-line

fixes vuetifyjs#5076

* fix(v-list-tile-action): add support for v-html

fixes vuetifyjs#5037

* fix(v-navigation-drawer): pull in Dependent mixin for click-outside

* feat(v-carousel): convert to ts

* refactor(v-carousel): update review items

* chore(v-carousel): update type

* refactor(v-carousel): update feedback items

* feat(dependent): convert to ts

* feat(filterable): convert to ts

* feat(returnable): convert to ts

* feat(components-index): convert to ts

* feat(colorable): convert to ts

* refactor(colors.d.ts): move file

* fix(translatable): partially revert 5f661a3

reverted back to original logic to correct scrolling bug

fixes vuetifyjs#4847

* [release] 1.2.4

* style(v-pagination): button cutting the page number

When props:length is a very large number,
the number of the button protrudes.

# <type>: (If applied, this commit will...) <subject> (Max 50 char)
# |<----  Using a Maximum Of 50 Characters  ---->| Hard limit to 72 -->|

# Explain why this change is being made
# |<----   Try To Limit Each Line to a Maximum Of 72 Characters   ---->|

# Provide links to any relevant issues, articles, commits, or other
# pull requests
# Example: See #23, fixes vuetifyjs#58

# --- COMMIT END ---
# <type> can be
#    feat     (new feature)
#    fix      (bug fix)
#    refactor (refactoring production code)
#    style    (formatting, missing semi colons, etc; no code change)
#    test     (adding or refactoring tests; no production code change)
#    chore    (updating npm scripts etc; no production code change)
# --------------------
# Remember to
#    Capitalize the subject line
#    Use the imperative mood in the subject line
#    Do not end the subject line with a period
#    Separate subject from body with a blank line (comments don't count)
#    Use the body to explain what and why vs. how
#    Can use multiple lines with "-" for bullet points in body
#
# If you can't summarize your changes in a single line, they should
# probably be split into multiple commits
# --------------------
# For more information about this template, check out
# https://gist.github.com/adeekshith/cd4c95a064977cdc6c50

* fix(iterable): rows-per-page selector not inheriting theme

* [release] 1.2.5

* fix(VStepperStep): use colorable mixin

fixes vuetifyjs#5183

* test for vuetifyjs#5183

* Fix vuetifyjs#4760: show next pagination page if current page is last

* [release] 1.2.6

* fix(v-radio): remove bottom margin

if only or last child, do not add margin

fixes vuetifyjs#5162

* fix(v-autocomplete): allow setSearch for numeric 0

fixes vuetifyjs#5110

* [v-tab] Fix anchor hash routing (vuetifyjs#5124)

* fix(v-messages): change assigned key

fixes vuetifyjs#4880

* fix(v-select): remove change event for external changes

fixes vuetifyjs#5006

* fix(v-text-field): change mouseup focus to conditional

should only focus the input if the originating mousedown was on the element

fixes vuetifyjs#5018

* fix(VLinearProgress): invalid class applied when using css color

* fix(VEditDialog): apply theme classes to content (vuetifyjs#5152)

* fix(VEditDialog): apply theme classes to content

fixes vuetifyjs#5127

* test: update snapshots

* [release] 1.2.7

* fix(v-ripple): decrease click target size on selection control ripple (vuetifyjs#5250)

hopefully removes instances where click targets overlap between adjacent inputs

closes vuetifyjs#2661

* fix(v-stepper): add registrable mixin

fixes vuetifyjs#3330

* fix(v-select): change isDisabled conditional

should use regular text color when readonly

fixes vuetifyjs#5051

* fix(v-dialog): always remove scrollbar when fullscreen

fixes vuetifyjs#3101

* fix(v-ripple): only modify position if current one is static (vuetifyjs#5249)

* fix(v-ripple): only modify position if current one is static

solves problems when using for example position sticky

closes vuetifyjs#2573

* chore(ripple): ignore eslint for max-statements

* [release] 1.2.8
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@johnleider johnleider

Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v1.2.x
Development

No branches or pull requests
3 participants
@johnleider @KaelWD @hymair