Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] disable-keys doesn't affect VMenu hiding when Esc key is pressed #12998

Closed
mattnathan opened this issue Jan 21, 2021 · 2 comments · Fixed by #16464
Closed

[Bug Report] disable-keys doesn't affect VMenu hiding when Esc key is pressed #12998

mattnathan opened this issue Jan 21, 2021 · 2 comments · Fixed by #16464
Assignees
Labels
C: VMenu VMenu has workaround T: bug Functionality that does not work as intended/expected

Comments

@mattnathan
Copy link

Environment

Vuetify Version: 2.3.21
Vue Version: 2.6.12
Browsers: Chrome 87.0.4280.141
OS: Windows 10

Steps to reproduce

  1. Create a v-menu with disable-keys (and probably close-on-content-click=false)
  2. Inside the menu place something that can receive text input (e.g. v-text-field)
  3. Run, open the menu, focus the text input, tap the ESC key

Expected Behavior

disable-keys says that "Removes all keyboard interaction", I would expect the menu to remain visible after tapping ESC

Actual Behavior

The menu hides

Reproduction Link

https://codepen.io/mattnathan/pen/jOMRLvv

Other comments

You can work around this by capturing the ESC keydown event and stopPropagation on it, but disable-keys should work

@ghost ghost added the S: triage label Jan 21, 2021
@ElijahKotyluk ElijahKotyluk added C: VMenu VMenu has workaround T: bug Functionality that does not work as intended/expected and removed S: triage labels Jan 26, 2021
tc-kelpiffner added a commit to kevin-ireland-tc/vuetify that referenced this issue Jan 17, 2023
@lioneaglesolutions
Copy link
Collaborator

This issue is being closed due to inactivity.

If you have any additional questions, please reach out to us in our [Discord community](https://community.vuetifyjs.com/).

@johnleider if happy, please also close related PR #16464

@lioneaglesolutions lioneaglesolutions closed this as not planned Won't fix, can't repro, duplicate, stale May 4, 2023
@johnleider
Copy link
Member

The PR is simple enough that we can keep them both open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu has workaround T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants