Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If typescript is enabled then modify the tsconfig.json #104

Closed
wants to merge 1 commit into from

Conversation

StummeJ
Copy link

@StummeJ StummeJ commented Aug 6, 2019

This will add vuetify under the tsconfig.json types. This prevents webpack from freaking out about unknown types.

@KaelWD
Copy link
Member

KaelWD commented Aug 8, 2019

Duplicate of #77

tsconfig is a superset of json, JSON.parse can fail if they've modified it

@StummeJ
Copy link
Author

StummeJ commented Aug 8, 2019

@KaelWD This would break a bunch of plugins then... this is how Vue-CLI is doing it. Also if it's a JSON file extension shouldn't if follow the JSON spec?

@johnleider
Copy link
Member

@KaelWD Could you elaborate on how it would fail? If it's valid JSON, it should simply work

@KaelWD
Copy link
Member

KaelWD commented Aug 9, 2019

Ok, I guess if vue-cli aren't doing it properly either then this can't hurt.

tsc has a special parser just for tsconfig to support shit like comments and trailing commas, both of which will cause JSON.parse() to throw

@johnleider
Copy link
Member

Pulse check, is this still being worked on?

@johnleider
Copy link
Member

This Pull Request is being closed due to inactivity.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants