Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr)!: include device pixel ratio in w/h calculation #199

Merged
merged 5 commits into from
Jul 21, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Feb 20, 2024

This PR sets Vuetify SSR flag to true when SSR enabled

There is a problem with Chrome running on Android, sending weird viewport size.

We need to request device pixel ratio (Sec-CH-DPR) to calculate the right width/height.

WICG/responsive-image-client-hints#23

https://twitter.com/userquin/status/1760047138762064277

Using Samsumg Galaxy S22 Ultra:

GGzwwW1awAASbQt

closes #205
closes #232

related #197

Copy link

netlify bot commented Feb 20, 2024

Deploy Preview for vuetify-nuxt-module ready!

Name Link
🔨 Latest commit 60ad800
🔍 Latest deploy log https://app.netlify.com/sites/vuetify-nuxt-module/deploys/669cbfea96b66b0009f4f751
😎 Deploy Preview https://deploy-preview-199--vuetify-nuxt-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin userquin marked this pull request as draft February 21, 2024 12:06
@userquin userquin changed the title fix: change SSR client hints server plugin order fix(ssr): include device pixel ratio in w/h calculation Feb 28, 2024
@userquin userquin marked this pull request as ready for review July 20, 2024 11:29
@userquin userquin changed the title fix(ssr): include device pixel ratio in w/h calculation fix(ssr)!: include device pixel ratio in w/h calculation Jul 21, 2024
@userquin userquin merged commit b80851d into main Jul 21, 2024
4 checks passed
@userquin userquin deleted the userquin/fix-ssr-client-hints-server-plugin-last branch July 21, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration style mismatch on <VMain /> hydration mismatch for z-index
1 participant