refactor: updated order details totals section styling #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderDevitsky
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
bartoszherba
requested changes
May 13, 2022
| @@ -6,8 +6,10 @@ export default gql` | |||
| orders(currentPage: $currentPage, filter: $filter, pageSize: $pageSize) { | |||
| items { | |||
| order_number | |||
| number | |||
| id | |||
| created_at | |||
There was a problem hiding this comment.
You can remove created_at
There was a problem hiding this comment.
@bartoszherba I caught the style error and fixed it. I also noticed that the new SingleOrder.vue component was created and already made all the new changes to this component.
AlexanderDevitsky
force-pushed
the
feat/m2-508-update-order-details-totals-section-styling
branch
from
f6ca603 to
1bb118c
Compare
| @@ -43,7 +43,7 @@ | |||
| v-for="order in orders" | |||
| :key="order.order_number" | |||
| > | |||
| <SfTableData>{{ order.order_number }}</SfTableData> | |||
| <SfTableData>{{ orderGetters.getId(order) }}</SfTableData> | |||
There was a problem hiding this comment.
Please, revert that. We are trying to get rid of getters whenever it is possible to reduce the bundle size, especially if getter does not introduce any intermediate logic but is a pure object prop accessor like in this case.
| @@ -52,7 +52,7 @@ | |||
| <SfTableData class="orders__view orders__element--right"> | |||
| <SfLink | |||
| data-cy="order-history-btn_view" | |||
| :link="localeRoute({ name: 'customer-single-order', params: { orderId: order.order_number } })" | |||
| :link="localeRoute({ name: 'customer-single-order', params: { orderId: orderGetters.getId(order) } })" | |||
There was a problem hiding this comment.
Same here, as in comment above.
There was a problem hiding this comment.
@bartoszherba Thank you for the info. Reverted these changes to the previous state
bartoszherba
approved these changes
May 13, 2022
sethidden
added a commit
that referenced
this pull request
May 13, 2022
This was re-added because of getters in #988 but was later removed during code review. I'll update the getters aswell so nobody is confused
Frodigo
changed the title
Frodigo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated styles for order details section
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: