Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skeleton loaders in category navbar #936

Merged
merged 1 commit into from
May 4, 2022
Merged

feat: add skeleton loaders in category navbar #936

merged 1 commit into from
May 4, 2022

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Apr 28, 2022 •
edited
Loading

Description

add skeleton loaders in category navbar

How Has This Been Tested?

  • Visit category page, execute any action eg. add filter
  • Observe that skeletons are now masking loaded fields

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-450-loading-skeleton-for-category-toolbar branch from fe3ed4a to 5d27ab5 Compare April 28, 2022 08:14
sethidden
sethidden requested changes Apr 29, 2022
View reviewed changes
Copy link
Contributor

@sethidden sethidden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CategoryNavbar still has some layout shift on narrow viewports. Namely, the "14 items" shifts a bit to the left. I'm only talking about the layout shift in CategoryNavbar, not the other ones (sidebar etc), since this PR is only about Category Navbar
https://user-images.githubusercontent.com/5359825/165923395-18646955-6136-4e03-972a-05219edd4e72.mov

packages/theme/components/SkeletonLoader/index.vue Show resolved Hide resolved
@Frodigo Frodigo requested a review from sethidden April 29, 2022 10:21
@bartoszherba bartoszherba force-pushed the M2-450-loading-skeleton-for-category-toolbar branch from 5d27ab5 to 626f64a Compare April 29, 2022 12:31
@Frodigo Frodigo added this to the 1.0.0-rc.8 milestone May 4, 2022
@bartoszherba bartoszherba merged commit 3db022b into develop May 4, 2022
@bartoszherba bartoszherba deleted the M2-450-loading-skeleton-for-category-toolbar branch May 4, 2022 11:50
@Frodigo Frodigo mentioned this pull request May 10, 2022
Merged
This was referenced May 25, 2022
Merged
Merged
@Frodigo Frodigo mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frodigo Frodigo Frodigo approved these changes

@sethidden sethidden sethidden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc.8
Development

Successfully merging this pull request may close these issues.
3 participants
@bartoszherba @sethidden @Frodigo