Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci!: simplify env config #813

Merged
merged 2 commits into from
Apr 5, 2022
Merged

ci!: simplify env config #813

merged 2 commits into from
Apr 5, 2022

Commits on Apr 5, 2022

  1. ci: simplify env config 

    BREAKING: rename certain env vars
MAGENTO_GRAPHQL -> MAGENTO_GRAPHQL_URL
REDIS__* (HOST etc.) -> REDIS_*
MAGENTO_EXTERNAL_CHECKOUT -> MAGENTO_EXTERNAL_CHECKOUT_ENABLED
_ENABLED env vars will only enable things if you set their value to
"true" (MY_ENV_VAR=true)

remove convict and related format package because convict cannot be used
in a browser - BREAKING: use .env in packages/theme instead of packages/theme/config/[env].json

remove dotenv because nuxt already uses dotenv under the hood

stop using GitHub repository secrets that are not actually secrets

refactor: remove convict and dotenv

dotenv is already used by nuxt under the hood

remove leftover config import

add sentry_dsn to dockerfile args
    @sethidden
    sethidden committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ea50ca1 View commit details
    Browse the repository at this point in the history

  2. ci!: add VSF_ prefix to environment variables 

    add VSF_ prefix where omitted
    @sethidden
    sethidden committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5ec31a9 View commit details
    Browse the repository at this point in the history