Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: search customer is not being moved to product details page #665

Conversation

KevinGorjan
Copy link
Contributor

Fix for: #625

Description

There is a directive active "click-outside" of an element. This was available on only the search-input field. So when you click on something else than the input-field, the search results are removed before the routing can take place.
This issue is fixed now.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KevinGorjan KevinGorjan changed the title fix: search customer is not being moved to product details page [DONT MERGE] - fix: search customer is not being moved to product details page Feb 25, 2022
@KevinGorjan KevinGorjan changed the title [DONT MERGE] - fix: search customer is not being moved to product details page fix: search customer is not being moved to product details page Feb 25, 2022
@Frodigo Frodigo merged commit 32d8ad8 into develop Feb 25, 2022
@Frodigo Frodigo deleted the bug/m2-201-Search-Customer-is-not-being-moved-to-Product-Details-page branch February 25, 2022 12:18
@Frodigo Frodigo added this to the Stable 1.0.0 release milestone Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants