Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect checkbox styling #656

Merged
merged 4 commits into from
Feb 23, 2022

Conversation

KevinGorjan
Copy link
Contributor

@KevinGorjan KevinGorjan commented Feb 23, 2022

Fix #544

Description

Styling was correct, but the way the selected filters values were passed to the filters on desktop and mobile was different.
During filtering, at a certain moment, the selected data failed because on the mobile the price filter was a checkbox while it was a radio button on the desktop-view. The data is different for a checkbox and a radio button. This is resolved now.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo merged commit 259f653 into develop Feb 23, 2022
@Frodigo Frodigo deleted the bug/m2-141-incorrect-checkbox-styling branch February 23, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants