Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: asset optimization #628

Merged
merged 1 commit into from
Feb 23, 2022
Merged

feat: asset optimization #628

merged 1 commit into from
Feb 23, 2022

Conversation

AlexanderDevitsky
Copy link
Contributor

@AlexanderDevitsky AlexanderDevitsky commented Feb 18, 2022 •
edited
Loading

Description

Related Issue

#397
https://vsf.atlassian.net/browse/M2-45

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo changed the title feat: Asset Optimization feat: asset optimization Feb 18, 2022
Frodigo
Frodigo previously approved these changes Feb 23, 2022
View reviewed changes
Copy link
Collaborator

@Frodigo Frodigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderDevitsky looks good to me. Please resolve conflicts, then I will merge it and we will be able to test your solution on our servers.

Thanks,
Marcin

@AlexanderDevitsky AlexanderDevitsky force-pushed the feat/m2-45-asset-optimization branch from 06b5767 to fbe8bb8 Compare February 23, 2022 12:48
@AlexanderDevitsky
Copy link
Contributor Author

@Frodigo resolved

@Frodigo Frodigo merged commit 488e7a3 into vuestorefront:develop Feb 23, 2022
@Frodigo Frodigo added this to the 1.0.0-rc.6 milestone Mar 8, 2022
@Frodigo Frodigo mentioned this pull request Mar 8, 2022
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frodigo Frodigo Frodigo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc.6
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderDevitsky @Frodigo