perf(theme): prevent loading unnecessary data on a mobile device in A… #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frodigo
requested changes
Feb 18, 2022
bartoszherba
force-pushed
the
M2-185-make-navigation-in-app-header-lazy-loaded
branch
from
e6fe207 to
ebf0188
Compare
bartoszherba
force-pushed
the
M2-185-make-navigation-in-app-header-lazy-loaded
branch
2 times, most recently
from
48963e9 to
dda4502
Compare
Frodigo
previously approved these changes
Feb 21, 2022
- add @nuxtjs/device package to recognize used device - remove mobile observer from header and replave it with device recognition tool - navigation is now lazy loaded, categories required for a navigation are not loaded at all on mobile devices
bartoszherba
force-pushed
the
M2-185-make-navigation-in-app-header-lazy-loaded
branch
from
dda4502 to
dd167ac
Compare
Frodigo
approved these changes
Feb 21, 2022
This was referenced Mar 8, 2022
bartoszherba
restored the
M2-185-make-navigation-in-app-header-lazy-loaded
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent loading unnecessary data on a mobile device in AppHeader component
mobile devices
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: