refactor(general): refactor how and where the cart is loaded #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frodigo
requested changes
Feb 15, 2022
There was a problem hiding this comment.
Looks great @bartoszherba, I've added only one small suggestion. Besides, please make sure that build passes.
Thanks,,
Marcin
| @@ -263,9 +258,7 @@ export default defineComponent({ | |||
| }; | |||
|
|
|||
| onSSR(async () => { | |||
There was a problem hiding this comment.
It would be great if you change onSSr to useAsync composable from nxutjs/compisition-api
- add loadTotalQuantity method on the cart composable as sometimes this is the only information needed - add lazy load for a minicart - header will pull only total quantity data instead of loading whole cart
bartoszherba
force-pushed
the
M2-182-make-cart-sidebar-lazy-loaded
branch
from
a7539fc to
070a1d3
Compare
Frodigo
approved these changes
Feb 15, 2022
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Check cart items qty displayed in the header for many scenarios for guest, customer, cart merging etc.
Screenshots (if appropriate):
Types of changes
Checklist: