Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(theme): refactor useUiState #595

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

bartoszherba
Copy link
Collaborator

Description

refactor useUiState

  • add TS support
  • moved to appropriate catalog for a consistency

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Frodigo Frodigo merged commit addf29d into refactor/perf-improvements Feb 14, 2022
@Frodigo Frodigo deleted the M2-163-refactor-use-ui-state branch February 14, 2022 13:54
Frodigo added a commit that referenced this pull request Mar 10, 2022
…rent develop (#713)

* refactor(theme): refactored Page route to use asyncData

* perf(theme): refactored asyncData to useAsync on page.vue

* refactor(theme): restored redis support for cms pages

* refactor(theme): add nuxt/pinia module to manage app state (#568)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(theme): add core pinia module

* refactor(theme): refactored AppHeader to use the useAsync composable instead of onSSR (#570)

* refactor(theme): refactor useConfig composable (#572)

- mark composable useCnfig as deprecated
    - move composable to theme module
    - rework composable to get rid of core dependency and to utilize Pinia store

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(composables): moved the useExternalCheckout composable to theme (#571)

* refactor: m2-154. refactor use store composable to use pinia store (#576)

* temp use store

* refactor(theme): refactor useStore composable

- mark useStore as deprecated in composables
- add useStore composable in a theme module

BREAKING CHANGE: rework useStore composable

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: restored loadUser in app header

* refactor: useWishlist (#577)

* refactor: refactored context binding

* refactor: refactored useWishlist, fixed removing from wishlist in my account

* refactor: wishlist: cr changes

* refactor(theme):  M2 155. refactor useCurrency composable (#579)

* refactor(theme): move stores to pinia store

* refactor(theme): refactor useCurrency composable
BREAKING CHANGES:
- mark useCurrency as a deprecated in composables module
-  add refactored and lightweight useCurrency in theme with usage of pinia store management

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: useUser (#582)

* refactor: added new theme composable: useUser

* refactor(theme): changed useUser binding to the new composable

* refactor(useuser): added types

* docs: added depracated infor to useUser composable

* refactor: removed console.log

* refactor(theme): refactored UseForgotPassword (#583)

* refactor: refactored useCategory composable (#585)

* refactor: refactored useFacet composable (#587)

* refactor(theme): refactor useCart composable (#584)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: refactored useCategorySearch (#589)

* refactor(theme): refactor useContent composable (#590)

BREAKING CHANGE: - mark useContent as deprecated, implement useContent in theme package

* fix(theme): fix page component data load

* refactor: refactored usecontent to work with useasync composable

* refactor: a/B testing: changed config loading from on moundted to useFetch (#593)

* fix: fixed ssr issues (#594)

* refactor: restored chunks

* refactor: removed chunks

* test: a/b: disabled config loading, and navigation

* refactor(theme): refactor useUiState (#595)

Co-authored-by: Bartosz Herba <[email protected]>

* - fix issues with dynamic modules import
- fix issues with useUiState import

* - update cart store and usage of useCart composable

* - fix wishlist issues after merge

* - mark tests as skipped for a further refactor

* Update .github/workflows/deploy-vue-storefront-cloud.yml

Co-authored-by: Artur Tagisow <[email protected]>

* Update .github/workflows/deploy-vue-storefront-cloud.yml

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/theme/composables/useCart/commands/loadTotalQtyCommand.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/composables/src/composables/useConfig/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* - update docblocks

Co-authored-by: Marcin Kwiatkowski <[email protected]>
Co-authored-by: Bartosz Herba <[email protected]>
Co-authored-by: Artur Tagisow <[email protected]>
@bartoszherba bartoszherba restored the M2-163-refactor-use-ui-state branch April 11, 2022 06:49
@Frodigo Frodigo deleted the M2-163-refactor-use-ui-state branch April 20, 2022 04:34
Frodigo added a commit that referenced this pull request May 4, 2022
…rent develop (#713)

* refactor(theme): refactored Page route to use asyncData

* perf(theme): refactored asyncData to useAsync on page.vue

* refactor(theme): restored redis support for cms pages

* refactor(theme): add nuxt/pinia module to manage app state (#568)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(theme): add core pinia module

* refactor(theme): refactored AppHeader to use the useAsync composable instead of onSSR (#570)

* refactor(theme): refactor useConfig composable (#572)

- mark composable useCnfig as deprecated
    - move composable to theme module
    - rework composable to get rid of core dependency and to utilize Pinia store

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(composables): moved the useExternalCheckout composable to theme (#571)

* refactor: m2-154. refactor use store composable to use pinia store (#576)

* temp use store

* refactor(theme): refactor useStore composable

- mark useStore as deprecated in composables
- add useStore composable in a theme module

BREAKING CHANGE: rework useStore composable

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: restored loadUser in app header

* refactor: useWishlist (#577)

* refactor: refactored context binding

* refactor: refactored useWishlist, fixed removing from wishlist in my account

* refactor: wishlist: cr changes

* refactor(theme):  M2 155. refactor useCurrency composable (#579)

* refactor(theme): move stores to pinia store

* refactor(theme): refactor useCurrency composable
BREAKING CHANGES:
- mark useCurrency as a deprecated in composables module
-  add refactored and lightweight useCurrency in theme with usage of pinia store management

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: useUser (#582)

* refactor: added new theme composable: useUser

* refactor(theme): changed useUser binding to the new composable

* refactor(useuser): added types

* docs: added depracated infor to useUser composable

* refactor: removed console.log

* refactor(theme): refactored UseForgotPassword (#583)

* refactor: refactored useCategory composable (#585)

* refactor: refactored useFacet composable (#587)

* refactor(theme): refactor useCart composable (#584)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: refactored useCategorySearch (#589)

* refactor(theme): refactor useContent composable (#590)

BREAKING CHANGE: - mark useContent as deprecated, implement useContent in theme package

* fix(theme): fix page component data load

* refactor: refactored usecontent to work with useasync composable

* refactor: a/B testing: changed config loading from on moundted to useFetch (#593)

* fix: fixed ssr issues (#594)

* refactor: restored chunks

* refactor: removed chunks

* test: a/b: disabled config loading, and navigation

* refactor(theme): refactor useUiState (#595)

Co-authored-by: Bartosz Herba <[email protected]>

* - fix issues with dynamic modules import
- fix issues with useUiState import

* - update cart store and usage of useCart composable

* - fix wishlist issues after merge

* - mark tests as skipped for a further refactor

* Update .github/workflows/deploy-vue-storefront-cloud.yml

Co-authored-by: Artur Tagisow <[email protected]>

* Update .github/workflows/deploy-vue-storefront-cloud.yml

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/theme/composables/useCart/commands/loadTotalQtyCommand.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/composables/src/composables/useConfig/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* - update docblocks

Co-authored-by: Marcin Kwiatkowski <[email protected]>
Co-authored-by: Bartosz Herba <[email protected]>
Co-authored-by: Artur Tagisow <[email protected]>
Frodigo added a commit that referenced this pull request May 4, 2022
…rent develop (#713)

* refactor(theme): refactored Page route to use asyncData

* perf(theme): refactored asyncData to useAsync on page.vue

* refactor(theme): restored redis support for cms pages

* refactor(theme): add nuxt/pinia module to manage app state (#568)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(theme): add core pinia module

* refactor(theme): refactored AppHeader to use the useAsync composable instead of onSSR (#570)

* refactor(theme): refactor useConfig composable (#572)

- mark composable useCnfig as deprecated
    - move composable to theme module
    - rework composable to get rid of core dependency and to utilize Pinia store

Co-authored-by: Bartosz Herba <[email protected]>

* refactor(composables): moved the useExternalCheckout composable to theme (#571)

* refactor: m2-154. refactor use store composable to use pinia store (#576)

* temp use store

* refactor(theme): refactor useStore composable

- mark useStore as deprecated in composables
- add useStore composable in a theme module

BREAKING CHANGE: rework useStore composable

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: restored loadUser in app header

* refactor: useWishlist (#577)

* refactor: refactored context binding

* refactor: refactored useWishlist, fixed removing from wishlist in my account

* refactor: wishlist: cr changes

* refactor(theme):  M2 155. refactor useCurrency composable (#579)

* refactor(theme): move stores to pinia store

* refactor(theme): refactor useCurrency composable
BREAKING CHANGES:
- mark useCurrency as a deprecated in composables module
-  add refactored and lightweight useCurrency in theme with usage of pinia store management

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: useUser (#582)

* refactor: added new theme composable: useUser

* refactor(theme): changed useUser binding to the new composable

* refactor(useuser): added types

* docs: added depracated infor to useUser composable

* refactor: removed console.log

* refactor(theme): refactored UseForgotPassword (#583)

* refactor: refactored useCategory composable (#585)

* refactor: refactored useFacet composable (#587)

* refactor(theme): refactor useCart composable (#584)

Co-authored-by: Bartosz Herba <[email protected]>

* refactor: refactored useCategorySearch (#589)

* refactor(theme): refactor useContent composable (#590)

BREAKING CHANGE: - mark useContent as deprecated, implement useContent in theme package

* fix(theme): fix page component data load

* refactor: refactored usecontent to work with useasync composable

* refactor: a/B testing: changed config loading from on moundted to useFetch (#593)

* fix: fixed ssr issues (#594)

* refactor: restored chunks

* refactor: removed chunks

* test: a/b: disabled config loading, and navigation

* refactor(theme): refactor useUiState (#595)

Co-authored-by: Bartosz Herba <[email protected]>

* - fix issues with dynamic modules import
- fix issues with useUiState import

* - update cart store and usage of useCart composable

* - fix wishlist issues after merge

* - mark tests as skipped for a further refactor

* Update .github/workflows/deploy-vue-storefront-cloud.yml

Co-authored-by: Artur Tagisow <[email protected]>

* Update .github/workflows/deploy-vue-storefront-cloud.yml

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCart/index.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/theme/composables/useCart/commands/loadTotalQtyCommand.ts

* Update packages/composables/src/composables/useCategorySearch/index.ts

* Update packages/composables/src/composables/useConfig/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* Update packages/composables/src/composables/useContent/index.ts

* - update docblocks

Co-authored-by: Marcin Kwiatkowski <[email protected]>
Co-authored-by: Bartosz Herba <[email protected]>
Co-authored-by: Artur Tagisow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants