Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: new magento 2 cli docs #1427

Merged
merged 11 commits into from
Mar 22, 2023
Merged

docs: new magento 2 cli docs #1427

merged 11 commits into from
Mar 22, 2023

Conversation

skirianov
Copy link
Contributor

Docs changes to align with the new CLI process

Description

Restructured docs.

Joined both installation steps on the same page.

Removed Magento configuration as it's not required to be on a separate page anymore.

Edited Vue Storefront configuration to be only an advanced configuration.

Related Issue

Motivation and Context

With the new CLI tool, old docs are not suitable anymore.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [-] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@skirianov skirianov requested a review from a team as a code owner March 20, 2023 14:40
@skirianov skirianov changed the title docs for new magento 2 cli docs:for new magento 2 cli Mar 20, 2023
@skirianov skirianov changed the title docs:for new magento 2 cli docs: new magento 2 cli docs Mar 20, 2023
Copy link
Contributor

@mattmaribojoc mattmaribojoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, left some comments where things were confusing for me - probably because I don't have domain knowledge of Magento, so feel free to ignore if you think more context isn't needed.

docs/installation-setup/installation.md Outdated Show resolved Hide resolved
docs/installation-setup/installation.md Outdated Show resolved Hide resolved
docs/installation-setup/installation.md Show resolved Hide resolved
docs/installation-setup/installation.md Outdated Show resolved Hide resolved
docs/installation-setup/installation.md Show resolved Hide resolved
docs/installation-setup/installation.md Show resolved Hide resolved
docs/installation-setup/installation.md Outdated Show resolved Hide resolved
docs/installation-setup/installation.md Outdated Show resolved Hide resolved
bartoszherba
bartoszherba previously approved these changes Mar 21, 2023
@skirianov skirianov merged commit fb70730 into main Mar 22, 2023
@skirianov skirianov deleted the docs-magento-2-new-cli branch March 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants