refactor: remove style duplication in my account route components #1310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
previously approved these changes
Jul 26, 2022
| --tabs-conent-border-width: 0; | ||
| } | ||
| } | ||
|
|
||
| .message { |
There was a problem hiding this comment.
You're importing shared.scss which contains the .message class, but on this line there's also a .message class. Doesn't this mess with the styles? Even if not, I think it'd be worth it to rename resolve this naming conflict
There was a problem hiding this comment.
The .message class from shared.scss and from here is also somewhat similar (only difference is margin, no?), would it be possible to streamline into one .message class?
bartoszherba
force-pushed
the
M2-577-remove-style-duplication-in-my-account-route-components
branch
from
8d92f25 to
82cf938
Compare
sethidden
approved these changes
Jul 29, 2022
bartoszherba
deleted the
M2-577-remove-style-duplication-in-my-account-route-components
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove style duplication in my account route components
Motivation and Context
Refactoring
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: