fix: fix bug when media_gallery array is empty #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `getGallery` rather check the length of an array to get an accurate bool value than simple the array which will always return true.
bensinca
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
|
Hi @bensinca, thanks for your contribution. Could you change the base branch from the main to the develop branch? |
Frodigo
changed the title
bartoszherba
approved these changes
Jul 18, 2022
Frodigo
approved these changes
Jul 18, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
getGalleryrather check the length of an array to get an accurate bool value than simple the array which will always return true.Related Issue
#1266
Motivation and Context
If product type is
configurable_productthen check the length of themedia_galleryarray to get an accurate bool value, as an array will always return true.