Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed filters skeleton on mobile devices #1100

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

Frodigo
Copy link
Collaborator

@Frodigo Frodigo commented Jun 7, 2022

Before

before this change on the category page, there were filters loading skeleton on mobile devices, but on mobile devices, filters can be visible only in overlay

After

After this change loader skeleton for filters on the category page is not visible anymore on mobile devices.

@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 7, 2022
Copy link
Collaborator

@bartoszherba bartoszherba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After a deep investigation I believe that this is a good change.

@Frodigo Frodigo merged commit 2da5039 into develop Jun 8, 2022
@Frodigo Frodigo deleted the fix/M2-739-skeletons-on-category-page branch June 8, 2022 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants