Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: total price and discount calculation #1090

Merged
merged 1 commit into from
Jun 2, 2022
Merged

fix: total price and discount calculation #1090

merged 1 commit into from
Jun 2, 2022

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 2, 2022 •
edited
Loading

Description

Fix discount calculation and total price calculation on the checkout and minicart.

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2022-06-02 at 12 00 21
Screenshot 2022-06-02 at 12 00 30

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-717-checkout-total-price-is-wrongly-calculated-when-using-discounts branch from 7416c4b to f9ac5af Compare June 2, 2022 10:02
@bartoszherba bartoszherba force-pushed the M2-717-checkout-total-price-is-wrongly-calculated-when-using-discounts branch from f9ac5af to 797eaa7 Compare June 2, 2022 10:05
@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 2, 2022
@bartoszherba bartoszherba merged commit 0573a3a into develop Jun 2, 2022
@bartoszherba bartoszherba deleted the M2-717-checkout-total-price-is-wrongly-calculated-when-using-discounts branch June 2, 2022 12:03
@Frodigo Frodigo changed the title fix: m2-717. total price and discount calculation fix: total price and discount calculation Jun 10, 2022
@Frodigo Frodigo mentioned this pull request Jun 10, 2022
Merged
@Frodigo Frodigo mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frodigo Frodigo Frodigo approved these changes

@sethidden sethidden sethidden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-rc.9
Development

Successfully merging this pull request may close these issues.
3 participants
@bartoszherba @sethidden @Frodigo