Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: double check types in composables #1085

Merged
merged 2 commits into from
Jun 2, 2022

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Jun 1, 2022

Description

  • Clean up types in composables
  • Remove all agnostic interfaces

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bartoszherba bartoszherba force-pushed the M2-524-double-check-types-in-composables branch from a71d833 to 99b780c Compare June 1, 2022 08:31
Frodigo
Frodigo previously approved these changes Jun 1, 2022
@Frodigo Frodigo added this to the 1.0.0-rc.9 milestone Jun 1, 2022
@bartoszherba bartoszherba dismissed stale reviews from Frodigo and sethidden via 5ae0697 June 2, 2022 06:21
@bartoszherba bartoszherba merged commit 6d29de6 into develop Jun 2, 2022
@bartoszherba bartoszherba deleted the M2-524-double-check-types-in-composables branch June 2, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants