refactor: remove some instances of implicit any #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
commented
May 26, 2022
| const integrationKey = `$${tag}`; | ||
|
|
||
| if (!nuxtCtx.$vsf || !nuxtCtx.$vsf[integrationKey]) { | ||
| if (!nuxtCtx.$vsf || !(nuxtCtx.$vsf as Record<string, any>)[integrationKey]) { |
There was a problem hiding this comment.
Intentional cast with any since it's expected that you can assign anything
sethidden
commented
May 26, 2022
| locale: undefined, | ||
| country: undefined, | ||
| currency: undefined, | ||
| locale: undefined as undefined, |
sethidden
changed the title
sethidden
commented
May 26, 2022
| @@ -1,902 +1,15 @@ | |||
| /* istanbul ignore file */ | |||
There was a problem hiding this comment.
I asked about this file on Slack. I don't really see it being used apart from the few interfaces I left at the bottom.
sethidden
force-pushed
the
M2-647-enable-no-implicit-any
branch
from
ac81685 to
a17cde3
Compare
sethidden
commented
May 26, 2022
...s/theme/modules/customer/composables/useUserAddress/commands/createCustomerAddressCommand.ts
Outdated
Show resolved
Hide resolved
sethidden
force-pushed
the
M2-647-enable-no-implicit-any
branch
from
7af5dc0 to
9b44e15
Compare
Frodigo
reviewed
May 26, 2022
| @@ -1,6 +1,6 @@ | |||
| import type { CustomerCreateInput } from '~/modules/GraphQL/types'; | |||
|
|
|||
| export const generateUserData = (userData): CustomerCreateInput => { | |||
| export const generateUserData = (userData: any): CustomerCreateInput => { | |||
There was a problem hiding this comment.
Have you tried with Customer or User instead of any here?
There was a problem hiding this comment.
Yes but they didn't fit. This is M2-664
Frodigo
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this PR is meant to remove only implicit any, such as writing the below in a .ts file
I tried setting noImplicitAny in tsconfig so the cases I'm removing here wouldn't even build but there's too many cases to fix. Even after this PR, there are ~140 implicit any related errors left.
I only fixed the easy ones here. The ones that are left are more difficult (require changes in implementation, removal of certain files etc.)