docs: add composables docs #1062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipsobol
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
filipsobol
force-pushed
the
20220517-add-composables-docs
branch
from
6303c27 to
144c850
Compare
Frodigo
previously approved these changes
May 26, 2022
There was a problem hiding this comment.
Thanks for that @filipsobol, it's awesome!
Please resolve conflicts.
|
@Frodigo I resolved the conflict. I also asked @bartoszherba to review certain parts of the docs we discussed. I'll merge it after his approval. |
bartoszherba
requested changes
May 27, 2022
There was a problem hiding this comment.
All is good but useFetch description must be changes to avoid naming this hook as a lifecycle hook, please check https://composition-api.nuxtjs.org/lifecycle/usefetch/
filipsobol
force-pushed
the
20220517-add-composables-docs
branch
from
7d84905 to
cf5edd9
Compare
filipsobol
force-pushed
the
20220517-add-composables-docs
branch
from
7723f8e to
7680a23
Compare
bartoszherba
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR explains what composables are (with Magento-specific examples) and creates one page that lists all composables instead of listing each composable in the sidebar.
Preview:
