fix: issue with displaying product price od PDP and PLP #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
previously approved these changes
May 24, 2022
| props: { | ||
| product: { | ||
| type: Object as PropType<typeof useProductsWithCommonProductCardProps | null>, | ||
| default: () => null, |
There was a problem hiding this comment.
Shouldn't this be required? You're accessing product.__typename in the template which will crash if product is null
sethidden
reviewed
May 24, 2022
| }, | ||
| props: { | ||
| product: { | ||
| type: Object as PropType<typeof useProductsWithCommonProductCardProps | null>, |
There was a problem hiding this comment.
Suggested change
| type: Object as PropType<typeof useProductsWithCommonProductCardProps | null>, | |
| type: Object as PropType<ReturnType<typeof useProductsWithCommonProductCardProps>['productsWithCommonProductCardProps']['value'][number] | null>, |
Unfortunately this is the type you're looking for. Right now in this PR it's "the product prop is a function or null (typeof useProduct... is a function that accepts products)
What I suggested is the modified product returned by the commoncardprops
bartoszherba
force-pushed
the
M2-573-sale-its-not-marked-anywhere-on-products-and-has-wrong-label-filter
branch
from
92160fc to
e3e50d7
Compare
sethidden
approved these changes
May 25, 2022
bartoszherba
deleted the
M2-573-sale-its-not-marked-anywhere-on-products-and-has-wrong-label-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#973
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: