test: added tests for category sidebar component #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diegoalbag
requested review from
Frodigo,
bartoszherba and
sethidden
as code owners
Diegoalbag
force-pushed
the
test/m2-441-add-test-mobile-category-sidebar-component
branch
from
579981a to
add53f5
Compare
Diegoalbag
changed the title
Diegoalbag
force-pushed
the
test/m2-441-add-test-mobile-category-sidebar-component
branch
3 times, most recently
from
fe461c0 to
0dcdfb3
Compare
bartoszherba
requested changes
May 20, 2022
There was a problem hiding this comment.
@Diegoalbag
A few additional things to do
-
Please, rework all scripts from js to ts, I know it might be misleading that most tests are in js but this is in most cases a legacy code and was not updated yet. All new tests/mocks/utils/scripts-in-general are in TS.
-
Please, add additional tests:
- if the user click on a category without children he will be redirected to that category
- if the user click on a category with children deeper categories will be revealed
- if the user click on the back arrow (not the go back button) menu will be hidden
...og/category/components/sidebar/MobileCategorySidebar/__tests__/MobileCategorySidebar.spec.js
Outdated
Show resolved
Hide resolved
...og/category/components/sidebar/MobileCategorySidebar/__tests__/MobileCategorySidebar.spec.js
Outdated
Show resolved
Hide resolved
bartoszherba
requested changes
May 23, 2022
...og/category/components/sidebar/MobileCategorySidebar/__tests__/MobileCategorySidebar.spec.js
Outdated
Show resolved
Hide resolved
...og/category/components/sidebar/MobileCategorySidebar/__tests__/MobileCategorySidebar.spec.js
Outdated
Show resolved
Hide resolved
Diegoalbag
force-pushed
the
test/m2-441-add-test-mobile-category-sidebar-component
branch
from
0dcdfb3 to
7f50a09
Compare
|
@bartoszherba if you have a chance, please re-review this one, thanks! |
bartoszherba
approved these changes
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added unit tests for packages/theme/modules/catalog/category/components/sidebar/CategorySidebar.vue
Related Issue
https://vsf.atlassian.net/jira/software/c/projects/M2/boards/51?modal=detail&selectedIssue=M2-441
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: