chore: fix all remaining eslint errors

.eslintignore

@@ -1,4 +1,8 @@
 **/node_modules/**/*
 **/lib/*
 packages/api-client/src/types/GraphQL.ts
+packages/api-client/server
+packages/composables/lib
+packages/api-client/lib
 packages/theme/static/sw.js
+.eslintrc.js

.eslintrc.js

@@ -13,8 +13,8 @@ module.exports = {
     parser: '@typescript-eslint/parser',
     project: [
       resolve(__dirname, './tsconfig.json'),
-      resolve(__dirname, './packages/api-client/tsconfig.json'),
-      resolve(__dirname, './packages/composables/tsconfig.json'),
+      resolve(__dirname, './packages/api-client/tsconfig.eslint.json'),
+      resolve(__dirname, './packages/composables/tsconfig.eslint.json'),
       resolve(__dirname, './packages/theme/tsconfig.json'),
       resolve(__dirname, './packages/theme/tests/e2e/tsconfig.json'),
     ],
@@ -48,6 +48,12 @@ module.exports = {
         "promise/catch-or-return": "off", // conflicts with Cypress.Chainable
         "promise/always-return": "off",
       }
+    },
+    {
+      "files": ["internals/**/*"],
+      "rules": {
+        "unicorn/prefer-module": "off",
+      }
     }
   ]
 }

.github/workflows/test.yml

@@ -36,5 +36,10 @@ jobs:
       - name: Build packages
         run: yarn build
 
+        # typescript-eslint needs all packages to be built
+        # to check type-related linting rules
+      - name: Check for linting errors
+        run: yarn lint
+
       - name: Test theme
         run: yarn test:theme

commitlint.config.js

@@ -1 +1,2 @@
+// eslint-disable-next-line unicorn/prefer-module
 module.exports = { extends: ['@commitlint/config-conventional'] };

internals/eslint-import/index.js

@@ -5,5 +5,5 @@ module.exports = {
     './rules/extends',
     './rules/rules',
     './rules/settings',
-  ].map(require.resolve),
+  ].map((element) => require.resolve(element)),
 };

internals/eslint-jest/index.js

@@ -3,5 +3,5 @@ module.exports = {
     './rules/plugins',
     './rules/extends',
     './rules/rules',
-  ].map(require.resolve),
+  ].map((element) => require.resolve(element)),
 };

internals/eslint-typescript/index.js

@@ -3,5 +3,5 @@ module.exports = {
     './rules/plugins',
     './rules/extends',
     './rules/rules',
-  ].map(require.resolve),
+  ].map((element) => require.resolve(element)),
 };

internals/eslint/index.js

@@ -6,5 +6,5 @@ module.exports = {
     './rules/plugins',
     './rules/extends',
     './rules/rules',
-  ].map(require.resolve),
+  ].map((element) => require.resolve(element)),
 };

package.json

@@ -11,9 +11,10 @@
     "internals/*"
   ],
   "scripts": {
-    "build": "yarn build:api-client && yarn build:theme",
+    "build": "yarn build:api-client && yarn build:theme && yarn build:composables",
     "build:api-client": "cd packages/api-client && yarn build",
     "build:theme": "cd packages/theme && yarn build",
+    "build:composables": "cd packages/composables && yarn build",
     "contributors:add": "all-contributors add",
     "contributors:generate": "all-contributors generate",
     "dev:api-client": "cd packages/api-client && yarn dev",
@@ -22,7 +23,7 @@
     "docs:dev": "cd docs && yarn dev",
     "docs:build": "cd docs && yarn build",
     "graphql:codegen": "graphql-codegen --config codegen.yml",
-    "lint": "eslint . --ext .ts,.vue --fix",
+    "lint": "eslint .",
     "prepare": "[ -d '.husky' ] && (husky install && shx rm -rf .git/hooks && shx ln -s ../.husky .git/hooks) || true",
     "publish:api-client": "node ./scripts/publishApi.js",
     "start": "cd packages/theme && yarn start",

packages/api-client/__tests__/api/storeConfig/storeConfig.spec.ts

@@ -1,5 +1,5 @@
 import request from '../../setup/request';
-import {STORE_CONFIG_MOCK_RESP} from './../../mockData/api/storeConfig'
+import { STORE_CONFIG_MOCK_RESP } from '../../mockData/api/storeConfig';
 
 describe('[Magento-API-Client] storeConfig', () => {
   it('Fetching the storeConfig', async () => {
@@ -60,8 +60,8 @@ describe('[Magento-API-Client] storeConfig', () => {
               welcome
             }
           }
-        `
-      })
+        `,
+      }),
     });
     const { data } = await res.json();
 

packages/api-client/babel.config.js

@@ -1,9 +1,10 @@
+// eslint-disable-next-line unicorn/prefer-module
 module.exports = {
   presets: [
     ['@babel/preset-env', {
       targets: {
-        node: 'current'
-      }
-    }]
-  ]
+        node: 'current',
+      },
+    }],
+  ],
 };

packages/api-client/jest.config.js

@@ -23,7 +23,7 @@ module.exports = {
   testEnvironment: 'jsdom',
   transform: {
     '^.+\\.(m)js$': 'babel-jest',
-    '^.+\\.ts$': 'ts-jest'
+    '^.+\\.ts$': 'ts-jest',
   },
   transformIgnorePatterns: [
     'node_modules',

packages/api-client/possible-types.js

@@ -1,7 +1,9 @@
+/* eslint-disable unicorn/prefer-module */
 require('dotenv').config();
 const fetch = require('cross-fetch');
 const fs = require('fs');
 
+// eslint-disable-next-line promise/catch-or-return
 fetch(process.env.VSF_MAGENTO_GRAPHQL_URL, {
   method: 'POST',
   headers: { 'Content-Type': 'application/json' },
@@ -22,9 +24,11 @@ fetch(process.env.VSF_MAGENTO_GRAPHQL_URL, {
     `,
   }),
 }).then((result) => result.json())
+  // eslint-disable-next-line promise/always-return
   .then((result) => {
     const possibleTypes = {};
 
+    // eslint-disable-next-line no-underscore-dangle
     result.data.__schema.types.forEach((supertype) => {
       if (supertype.possibleTypes) {
         possibleTypes[supertype.name] = supertype.possibleTypes.map((subtype) => subtype.name);

packages/api-client/src/api/wishlist/index.ts

@@ -1,6 +1,5 @@
 import { ApolloQueryResult } from '@apollo/client/core';
 import { CustomQuery } from '@vue-storefront/core';
-import gql from 'graphql-tag';
 import {
   WishlistQuery,
   WishlistQueryVariables,

packages/api-client/tsconfig.eslint.json

@@ -0,0 +1,7 @@
+{
+  "extends": "../../tsconfig.json",
+  "exclude": [
+    "lib",
+    "node_modules"
+  ]
+}

packages/composables/__tests__/_mountComposable.ts

@@ -1,12 +1,12 @@
 import { shallowMount } from '@vue/test-utils';
-import { createComponent } from '@vue/composition-api';
+import { defineComponent } from '@vue/composition-api';
 
 const mountComposable = (composableFn) => {
-  const component = createComponent({
-    template: '<div>my component</div>',
+  const component = defineComponent({
     setup() {
       return composableFn();
     },
+    template: '<div>my component</div>',
   });
 
   return shallowMount(component);