chore: fix ~50 eslint errors #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethidden
changed the title
sethidden
commented
May 16, 2022
| { | ||
| "files": ["packages/theme/tests/e2e/**/*"], | ||
| "rules": { | ||
| "jest/expect-expect": "off", |
There was a problem hiding this comment.
cypress uses similar test case syntax to jest so eslint gets confused and treats cypress like jest. this solution is not optimal but will do for now
sethidden
commented
May 16, 2022
| @@ -41,8 +41,10 @@ | |||
| "@vue-storefront/nuxt": "~2.5.6", | |||
| "@vue-storefront/redis-cache": "^1.0.1", | |||
| "axios": "^0.26.1", | |||
| "body-parser": "1.19.2", | |||
There was a problem hiding this comment.
These were already used by body-parser.js - I'm just adding them explicitly, rather than using the transient versions provided by unrelated packages
sethidden
commented
May 16, 2022
bartoszherba
requested changes
May 17, 2022
|
Build issues fixed in b27b057 (non-trivial) |
bartoszherba
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second batch of manual eslint fixes. Error/warning count is 140 -> 96. These ones had to be made by hand.