feat(markdown): update default markdown-it-anchor permalink function (close #1363) #1452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
The heading anchors have
aria-hidden
attributes but are still focusable via keyboard navigation. There was a bit of discussion around this already in themarkdown-it-anchor
repo and you can address this by just using theheaderLink
render function instead of theariaHidden
render function since it wraps the entire header in an anchor.This fixes #1363
Screenshots
We will also need to make some changes to
theme-default
's base styles to accompany these changes. I will put that PR up shortly and include screenshots there.Before
After