Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdSelect): re-fix select content under dialog #1525

Merged
merged 1 commit into from
Mar 27, 2018

Conversation

onjiro
Copy link
Contributor

@onjiro onjiro commented Feb 18, 2018

Issue #1149 has been reproducted on v1.0.0-beta-8, after commit f0a7325 .
CSS specificity should not same as MdMenuContent.
It seems z-index on MdMenuContent overriding.

.md-menu-content {
@include md-elevation(8);
min-width: $md-menu-base-width * 2;
max-width: $md-menu-base-width * 5;
max-height: 35vh;
display: flex;
flex-direction: row;
position: absolute;
z-index: 60;
border-radius: 2px;
transition: transform .2s $md-transition-stand-timing,
opacity .3s $md-transition-stand-timing;
will-change: opacity, transform, top, left !important;

fix #1149
thanks.

@Samuell1
Copy link
Member

Samuell1 commented Feb 18, 2018

This is not a fix because you added same class to .md-menu-content that is few lines under it as &.md-select-menu

@onjiro
Copy link
Contributor Author

onjiro commented Feb 18, 2018

Sorry, I missed it. I'll fix.

@Samuell1
Copy link
Member

And i tested now select in dialog in dev branch and all things works.

@onjiro
Copy link
Contributor Author

onjiro commented Feb 18, 2018

Thank you for testing and notice.
Hmmm...but, this problem seems still existing in dev branch.
I tried npm run build and tested on dev branch.
If you tested on other way, could you try this?

Select content is begind dialog after commit f0a7325 .
Css specificity should not same as MdMenuContent.

fix vuematerial#1149
@Samuell1
Copy link
Member

Samuell1 commented Feb 18, 2018

When you try with npm run dev without fix it works? Because i think it can be issue in build process

@onjiro
Copy link
Contributor Author

onjiro commented Feb 18, 2018

OK. It works fine with npm run dev without fix.

This issue is caused by same CSS specificity.
It makes components flagile. So I think to fix CSS is better than to fix build process. thanks.

@Samuell1
Copy link
Member

@onjiro CSS is fixed, but build process is removing, changing some CSS and thats why it doesnt work. @marcosmoura Can you look at it?

@marcosmoura
Copy link
Member

@onjiro @Samuell1 I will take a look at it today.

@JRakhimov
Copy link

So is there any solutions for this problem?

@marcosmoura
Copy link
Member

@JRakhimov Not yet. We will upgrade the build system, so this problem will be vanished.

@marcosmoura marcosmoura merged commit f7990c5 into vuematerial:dev Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[md-select] Select is behind dialog
4 participants