Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(MdMenu): fix close-on-select props #1280

Merged
merged 1 commit into from
Dec 19, 2017
Merged

fix(MdMenu): fix close-on-select props #1280

merged 1 commit into from
Dec 19, 2017

Conversation

VdustR
Copy link
Member

@VdustR VdustR commented Dec 8, 2017

check whether clicked target is contained in menu content element within bodyClickObserver

I found that this.$el is always <!-- --> here. Add a statement isMenuContentEl to prevent menu closing from bodyClickObserver.

MdMenu, MdSelect, MdAutocomplete tested.

Note that md-close-on-select only fire close event fired while there are one or more interaction events bound on md-menu-item

fix #1279

@VdustR
fix(MdMenu): fix close-on-select props
f3fd5b6 
check whether clicked target is contained in menu content element within `bodyClickObserver`

fix #1279
@marcosmoura marcosmoura merged commit 40406af into vuematerial:dev Dec 19, 2017
@VdustR VdustR deleted the fix#1279 branch December 19, 2017 03:50
@hastom hastom mentioned this pull request Jul 12, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 13, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcosmoura marcosmoura marcosmoura approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu :md-close-on-select="false" not working
2 participants
@VdustR @marcosmoura