Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdAppDrawer, MdAppContent, MdAppToolbar in PascalCase don't display inside MdApp #1992

Closed
hastom opened this issue Jan 11, 2019 · 5 comments
Closed

Comments

@hastom
Copy link
Contributor

hastom commented Jan 11, 2019

Steps to reproduce

Forked vue-material quick start example,
Made simple MdApp with toolbar, content and drawer.
All components written in PascalCase

Which browser?

vue: latest
vue-material: latest

Browser: Chrome 71

What is expected?

App with toolbar, drawer and content

What is actually happening?

Nothing

Reproduction Link

https://codesandbox.io/s/o7qo94np5y

@zapping
Copy link
Contributor

zapping commented Jan 14, 2019

According to Vuejs docs

In most projects, component names should always be PascalCase in single-file components and string templates - but kebab-case in DOM templates.

https://vuejs.org/v2/style-guide/#Component-name-casing-in-templates-strongly-recommended

@hastom
Copy link
Contributor Author

hastom commented Jan 14, 2019

@zapping problem occurs in single-file component not in a DOM template

@Samuell1
Copy link
Member

@hastom Like @zapping said you should not use pascal case in template.

For now you can fix it on your side by just renaming MdAppDrawer to md-app-drawer.

@hastom
Copy link
Contributor Author

hastom commented Jan 24, 2019

@Samuell1 but according to the docs it's strongly recommended to use Pascal case in single-file components. Certanly i can fix it by renaming, but it should work in both cases

@Samuell1
Copy link
Member

Yeah, thanks for PR!. I look at your PR later and if everything will be fine i merge it to dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants