Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MdChips] custom duplicated checking method #1288

Closed
VdustR opened this issue Dec 9, 2017 · 1 comment · Fixed by #1339
Closed

[MdChips] custom duplicated checking method #1288

VdustR opened this issue Dec 9, 2017 · 1 comment · Fixed by #1339
Labels
improvement

Comments

@VdustR
Copy link
Member

VdustR commented Dec 9, 2017 •
edited
Loading

As we have rejecting duplicated chip by comparing strings whether they are equal, I think we could add an optional props for the comparing method for cases like regarding apple and Apple as the same chip or regarding accent characters like e, è(String.fromCharCode(0x65, 0x300)), è(String.fromCharCode(0xe8)) as the same character.
@VdustR VdustR changed the title [MdChips] feature - custom duplicated checking method [MdChips] custom duplicated checking method Dec 9, 2017
@Samuell1
Copy link
Member

Maybe we can use fuzzy search like table is using?

@VdustR VdustR mentioned this issue Dec 25, 2017
Merged
marcosmoura pushed a commit that referenced this issue Jan 12, 2018
@VdustR @marcosmoura
feat(MdChips): add formatter for individual chips (#1339)
247a840 
* feat(MdChips): formatter

Formatter before chip insertion. Effects to insertion and duplicated-checking.

fix #1288

* style(MdChips): always return a value

* docs(Chips): fix `md-format` API description

#1339 (comment)

* docs(ChipsFormat): fix component name and example message

* docs(ChipsFormat): `formatName` return result directly

#1339 (comment)

* style(MdChips): add a space before `if` statement

#1339 (comment)

* docs(Chips): better message for formatter

#1339 (comment)

* fix: code style
@snyk-bot snyk-bot mentioned this issue Feb 13, 2020
Closed
@snyk-bot snyk-bot mentioned this issue Mar 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
2 participants
@Samuell1 @VdustR