Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add docs and typings for the new hasModule method #1706

Merged
merged 1 commit into from
Apr 12, 2020
Merged

docs: add docs and typings for the new hasModule method #1706

merged 1 commit into from
Apr 12, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Mar 30, 2020

This PR adds docs and typing for the new hasModule API which was added at #834.

@kiaking kiaking added documentation Improvements or additions to documentation types Related to typings only labels Mar 30, 2020
@kiaking kiaking requested a review from ktsn March 30, 2020 15:25
@kiaking kiaking self-assigned this Mar 30, 2020
ktsn
ktsn approved these changes Apr 12, 2020
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ktsn ktsn merged commit b49abc0 into dev Apr 12, 2020
@kiaking kiaking deleted the has-module-type-and-docs branch April 13, 2020 05:37
vaga pushed a commit to vaga/vuex that referenced this pull request Apr 20, 2020
@kiaking @vaga
docs: add docs and typings for the new hasModule method (vuejs#1706)
7eed18d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees

@kiaking kiaking

Labels
documentation Improvements or additions to documentation types Related to typings only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiaking @ktsn