docs: make obvious where to import store from #1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we browse through the modules page, it is unclear where the `store` is imported from. Since it is a one liner, I thought it would clarify to have the import explicitly here. Tell me what you think.
|
You can't import |
|
Thank you @ktsn. |
ktsn
reviewed
Mar 3, 2020
|
@elevatebart Hi! How is't going? Would it be possible for you to update the docs including comment from ktsn? |
Co-Authored-By: Katashin <[email protected]>
|
御免なさい... (^^;) |
|
Thanks! Looking good to me. What do you say @ktsn ? |
andrewminer
pushed a commit
to andrewminer/vuex
that referenced
this pull request
Mar 19, 2020
* docs: make obvious where to import store from As we browse through the modules page, it is unclear where the `store` is imported from. Since it is a one liner, I thought it would clarify to have the import explicitly here. Tell me what you think. * docs: import vuex instead of store Co-Authored-By: Katashin <[email protected]> Co-authored-by: Katashin <[email protected]>
vaga
pushed a commit
to vaga/vuex
that referenced
this pull request
Apr 20, 2020
* docs: make obvious where to import store from As we browse through the modules page, it is unclear where the `store` is imported from. Since it is a one liner, I thought it would clarify to have the import explicitly here. Tell me what you think. * docs: import vuex instead of store Co-Authored-By: Katashin <[email protected]> Co-authored-by: Katashin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we browse through the modules page, it is unclear where the
storeis imported from.Since it is a one liner, I thought it would clarify to have the import explicitly here.
Tell me what you think.