Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove leading markup from h1 header (closes #693, closes #689) #694

Closed
wants to merge 1 commit into from
Closed

feat: remove leading markup from h1 header (closes #693, closes #689) #694

wants to merge 1 commit into from

Conversation

roberthamel
Copy link

@roberthamel roberthamel commented Aug 2, 2018

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
I'm not sure if all the tests cover enough scenarios. Also, is there any documentation that would need updating?

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but this isn't a correct solution.

}
exports.removeTailHtml = (str) => String(str)
.replace(/\s*?<.*>\s*$/g, '')
.replace(/\s`<(.*?)\/>`$/g, ' <code><$1></code>')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <code> was generated by markdown loader instead of this method.

@ulivz
Copy link
Member

ulivz commented Aug 8, 2018

Thanks for the good work, closing it since we have had a correct solution at #711.

@ulivz ulivz closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants