-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow injecting Vue #61
Conversation
Since the new version has supported to eject the default theme (89538fa) which can let you to mutate the Vue constructor, so I'm not sure whether it's necessary. Maybe this PR is good for those users who don't want to eject theme but still want to extend Vue. |
@ulivz The new feat EJECT is good to develop a new theme. But most of the time, we just need to extend Vue. What's more, we want keep it independent on THE THEME. |
lib/prepare.js
Outdated
`inject(Vue)` | ||
) | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe adding a webpack alias to this file and import it in lib/app/app.js
would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, This solution would be better.
And there's no need to inject |
This PR is helpful for component developers to show their components, e.g.
.vuepress/inject.js
:components/button.md
: