feat: better sidebar transition #556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
force-pushed
the
master
branch
3 times, most recently
from
14d9013 to
c7c0cd9
Compare
ulivz
force-pushed
the
master
branch
5 times, most recently
from
c992e38 to
c2eaff3
Compare
ulivz
force-pushed
the
master
branch
4 times, most recently
from
0c3bc3a to
cf1e6fc
Compare
ulivz
force-pushed
the
master
branch
2 times, most recently
from
bd69d41 to
903138e
Compare
ulivz
force-pushed
the
master
branch
2 times, most recently
from
3f79224 to
fb05066
Compare
ulivz
force-pushed
the
master
branch
2 times, most recently
from
04f50a4 to
edcf194
Compare
ulivz
force-pushed
the
master
branch
5 times, most recently
from
316e022 to
1284944
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR leverages the transition of vue.js official website and also enhances the mobile's style when sidebar slide in from the left side. It hides header, which allows users to focus more on sidebar.
Before:
Option 1
Hmmm... the
box-shadowlooks not very good in this gif, thisbox-shadowis also migrated from official website. so add a extra static snapshot here:Option 2
@yyx990803 which one do you prefer?